Patch for bug 17256 'possible bug in writeForeignSAS in the foreign library when string is NA'

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for bug 17256 'possible bug in writeForeignSAS in the foreign library when string is NA'

NELSON, Michael
Attached is a patch to fix https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=17256

'possible bug in writeForeignSAS in the foreign library when string is NA'



The patch
1. fixing the case where there were NA within a character column,   and the case where all values are strings of length 0
2. general replacement of calls to `sapply` with `vapply` (and replacing any(is.na()) with anyNA.



Happy to  add in bugzilla (but don't have an account there)

Regards

Michael Nelson

_______________________________________________________________________________________________________
Disclaimer: This message is intended for the addressee named and may contain confidential information.
If you are not the intended recipient, please delete it and notify the sender.
Views expressed in this message are those of the individual sender, and are not necessarily the views of the NSW Ministry of Health.
_______________________________________________________________________________________________________
This email has been scanned for the NSW Ministry of Health by the Websense Hosted Email Security System.
Emails and attachments are monitored to ensure compliance with the NSW Ministry of Health's Electronic Messaging Policy.
_______________________________________________________________________________________________________
______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Reply | Threaded
Open this post in threaded view
|

Re: Patch for bug 17256 'possible bug in writeForeignSAS in the foreign library when string is NA'

Martin Maechler
>>>>> NELSON, Michael <[hidden email]>
>>>>>     on Thu, 17 May 2018 11:53:27 +0000 writes:

    > Attached is a patch to fix
    > https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=17256
    > 'possible bug in writeForeignSAS in the foreign library
    > when string is NA'



    > The patch 1. fixing the case where there were NA within a
    > character column, and the case where all values are
    > strings of length 0 2. general replacement of calls to
    > `sapply` with `vapply` (and replacing any(is.na()) with
    > anyNA.



    > Happy to add in bugzilla (but don't have an account there)

The patch attachment did not make it through the (antispam /
antivirus /... ) filters:
Such attachments should have MIME type text/plain.

I have created a bugzilla account for you(r e-mail) and you
should've gotten an auto-email with info.

Thank you in advance for helping with this.

In this special case, we'd also be happy for other users testing the
problem and the fix, as access to SAS may have become difficult
for most R core members.

Martin Maechler
ETH Zurich

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Reply | Threaded
Open this post in threaded view
|

Re: Patch for bug 17256 'possible bug in writeForeignSAS in the foreign library when string is NA'

NELSON, Michael
Hi Martin,

Thanks - I will continue in Bugzilla.

Michael

-----Original Message-----
From: Martin Maechler [mailto:[hidden email]]
Sent: Thursday, 17 May 2018 11:34 PM
To: NELSON, Michael
Cc: [hidden email]
Subject: Re: [Rd] Patch for bug 17256 'possible bug in writeForeignSAS in the foreign library when string is NA'

>>>>> NELSON, Michael <[hidden email]>
>>>>>     on Thu, 17 May 2018 11:53:27 +0000 writes:

    > Attached is a patch to fix
    > https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=17256
    > 'possible bug in writeForeignSAS in the foreign library
    > when string is NA'



    > The patch 1. fixing the case where there were NA within a
    > character column, and the case where all values are
    > strings of length 0 2. general replacement of calls to
    > `sapply` with `vapply` (and replacing any(is.na()) with
    > anyNA.



    > Happy to add in bugzilla (but don't have an account there)

The patch attachment did not make it through the (antispam / antivirus /... ) filters:
Such attachments should have MIME type text/plain.

I have created a bugzilla account for you(r e-mail) and you should've gotten an auto-email with info.

Thank you in advance for helping with this.

In this special case, we'd also be happy for other users testing the problem and the fix, as access to SAS may have become difficult for most R core members.

Martin Maechler
ETH Zurich
__________________________________________________________________________________________________________
This email has been scanned for the NSW Ministry of Health by the Websense Hosted Email Security System.
Emails and attachments are monitored to ensure compliance with the NSW Ministry of health's Electronic Messaging Policy.
__________________________________________________________________________________________________________
_______________________________________________________________________________________________________
Disclaimer: This message is intended for the addressee named and may contain confidential information.
If you are not the intended recipient, please delete it and notify the sender.
Views expressed in this message are those of the individual sender, and are not necessarily the views of the NSW Ministry of Health.
_______________________________________________________________________________________________________
This email has been scanned for the NSW Ministry of Health by the Websense Hosted Email Security System.
Emails and attachments are monitored to ensure compliance with the NSW Ministry of Health's Electronic Messaging Policy.

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel