Problems with "predict" function ii

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Problems with "predict" function ii

R help mailing list-2
I  have realised that I should have used "detach" before attaching another
dataframe, but even when I do this it's still giving me lots of lines, rather
than just one:

My code:


m<-runif(1,0,1)
m
mres<-m*(seq(1,12))
mres
ssd<-rexp(1,1)
ssd
devs<-rep(0,length(mres))
for(i in 1:length(mres)){devs[i]<-rnorm(1,0,ssd)}
devs
plot(-10,-10,xlim=c(1,24),ylim=c(0,20000))
sales<-round((mres+devs)*1000)

points(sales,pch=19)

ptr<-cbind(1:length(sales),sales,sales,sales)

ptr
sdf<-data.frame(cbind(1:nrow(ptr),sales))
sdf

colnames(sdf)<-c(“monat”,“mitte”)
sdf
attach(sdf)
s.lm<-lm(mitte~monat)

s.lm
abline(s.lm,lty=2)
news<-data.frame(monat=nrow(sdf)+1)
news
fcs<-predict(s.lm,news,interval=“predict”)
fcs

points(1+nrow(ptr),fcs[,1],col=“grey”,pch=19)
points(1+nrow(ptr),fcs[,2])
points(1+nrow(ptr),fcs[,3])
ptr<-rbind(ptr,c(1+nrow(ptr),fcs[2],fcs[1],fcs[3]))
ptr

highdf<-data.frame(ptr[,c(1,4)])
highdf
colnames(highdf)<-c(“month”,“sales”)
highdf
detach(sdf)
attach(highdf)
h.lm<-lm(highdf[,2]~highdf[,1])
h.lm
abline(h.lm,col="gray",lty=2)
news<-data.frame(month=nrow(ptr)+1)
news
hcs<-predict(h.lm,news,interval=“predict”)
hcs
        [[alternative HTML version deleted]]

______________________________________________
[hidden email] mailing list -- To UNSUBSCRIBE and more, see
https://stat.ethz.ch/mailman/listinfo/r-help
PLEASE do read the posting guide http://www.R-project.org/posting-guide.html
and provide commented, minimal, self-contained, reproducible code.
Reply | Threaded
Open this post in threaded view
|

Re: Problems with "predict" function ii

Jeff Newmiller
This is the kind of thing that leads experienced R users to avoid attach for data analysis. Read "The R Inferno".

Use the "data" argument to lm, and the "newdata" argument to predict.lm.
--
Sent from my phone. Please excuse my brevity.

On January 31, 2018 9:20:10 AM PST, WRAY NICHOLAS via R-help <[hidden email]> wrote:

>I  have realised that I should have used "detach" before attaching
>another
>dataframe, but even when I do this it's still giving me lots of lines,
>rather
>than just one:
>
>My code:
>
>
>m<-runif(1,0,1)
>m
>mres<-m*(seq(1,12))
>mres
>ssd<-rexp(1,1)
>ssd
>devs<-rep(0,length(mres))
>for(i in 1:length(mres)){devs[i]<-rnorm(1,0,ssd)}
>devs
>plot(-10,-10,xlim=c(1,24),ylim=c(0,20000))
>sales<-round((mres+devs)*1000)
>
>points(sales,pch=19)
>
>ptr<-cbind(1:length(sales),sales,sales,sales)
>
>ptr
>sdf<-data.frame(cbind(1:nrow(ptr),sales))
>sdf
>
>colnames(sdf)<-c(“monat”,“mitte”)
>sdf
>attach(sdf)
>s.lm<-lm(mitte~monat)
>
>s.lm
>abline(s.lm,lty=2)
>news<-data.frame(monat=nrow(sdf)+1)
>news
>fcs<-predict(s.lm,news,interval=“predict”)
>fcs
>
>points(1+nrow(ptr),fcs[,1],col=“grey”,pch=19)
>points(1+nrow(ptr),fcs[,2])
>points(1+nrow(ptr),fcs[,3])
>ptr<-rbind(ptr,c(1+nrow(ptr),fcs[2],fcs[1],fcs[3]))
>ptr
>
>highdf<-data.frame(ptr[,c(1,4)])
>highdf
>colnames(highdf)<-c(“month”,“sales”)
>highdf
>detach(sdf)
>attach(highdf)
>h.lm<-lm(highdf[,2]~highdf[,1])
>h.lm
>abline(h.lm,col="gray",lty=2)
>news<-data.frame(month=nrow(ptr)+1)
>news
>hcs<-predict(h.lm,news,interval=“predict”)
>hcs
> [[alternative HTML version deleted]]
>
>______________________________________________
>[hidden email] mailing list -- To UNSUBSCRIBE and more, see
>https://stat.ethz.ch/mailman/listinfo/r-help
>PLEASE do read the posting guide
>http://www.R-project.org/posting-guide.html
>and provide commented, minimal, self-contained, reproducible code.

______________________________________________
[hidden email] mailing list -- To UNSUBSCRIBE and more, see
https://stat.ethz.ch/mailman/listinfo/r-help
PLEASE do read the posting guide http://www.R-project.org/posting-guide.html
and provide commented, minimal, self-contained, reproducible code.
Reply | Threaded
Open this post in threaded view
|

Re: Problems with "predict" function ii

PIKAL Petr
In reply to this post by R help mailing list-2
Hi

First of all you should not post in HTML.

Thank you for posting the code, however I do not understand wht exactly do you mean by that you get many lines. I get only one with your code.

Other answers see in line

-----Original Message-----
From: R-help [mailto:[hidden email]] On Behalf Of WRAY NICHOLAS via R-help
Sent: Wednesday, January 31, 2018 6:20 PM
To: r-help <[hidden email]>
Subject: [R] Problems with "predict" function ii

I  have realised that I should have used "detach" before attaching another dataframe, but even when I do this it's still giving me lots of lines, rather than just one:



And you should not use attach, it is hardly ever necessary.

My code:


m<-runif(1,0,1)
m
mres<-m*(seq(1,12))
mres
ssd<-rexp(1,1)
ssd
devs<-rep(0,length(mres))
for(i in 1:length(mres)){devs[i]<-rnorm(1,0,ssd)}
devs
plot(-10,-10,xlim=c(1,24),ylim=c(0,20000))
sales<-round((mres+devs)*1000)

points(sales,pch=19)

ptr<-cbind(1:length(sales),sales,sales,sales)

ptr
sdf<-data.frame(cbind(1:nrow(ptr),sales))
sdf

colnames(sdf)<-c(“monat”,“mitte”)
sdf




attach(sdf)
s.lm<-lm(mitte~monat)


instead of attach use
s.lm<-lm(mitte~monat, data=sdf)


s.lm
abline(s.lm,lty=2)
news<-data.frame(monat=nrow(sdf)+1)
news
fcs<-predict(s.lm,news,interval=“predict”)
fcs

points(1+nrow(ptr),fcs[,1],col=“grey”,pch=19)
points(1+nrow(ptr),fcs[,2])
points(1+nrow(ptr),fcs[,3])
ptr<-rbind(ptr,c(1+nrow(ptr),fcs[2],fcs[1],fcs[3]))
ptr

highdf<-data.frame(ptr[,c(1,4)])
highdf
colnames(highdf)<-c(“month”,“sales”)
highdf
##detach(sdf)
##attach(highdf)
##h.lm<-lm(highdf[,2]~highdf[,1])
h.lm<-lm(sales~month, highdf)


h.lm
abline(h.lm,col="gray",lty=2)
news<-data.frame(month=nrow(ptr)+1)
news
hcs<-predict(h.lm,news,interval=“predict”)
hcs

I get a picture with two lines, black from you first call to the abline, second from your second call. What you want to achieve?

Cheers
Petr



        [[alternative HTML version deleted]]

______________________________________________
[hidden email] mailing list -- To UNSUBSCRIBE and more, see https://stat.ethz.ch/mailman/listinfo/r-help
PLEASE do read the posting guide http://www.R-project.org/posting-guide.html
and provide commented, minimal, self-contained, reproducible code.

________________________________
Tento e-mail a jakékoliv k němu připojené dokumenty jsou důvěrné a jsou určeny pouze jeho adresátům.
Jestliže jste obdržel(a) tento e-mail omylem, informujte laskavě neprodleně jeho odesílatele. Obsah tohoto emailu i s přílohami a jeho kopie vymažte ze svého systému.
Nejste-li zamýšleným adresátem tohoto emailu, nejste oprávněni tento email jakkoliv užívat, rozšiřovat, kopírovat či zveřejňovat.
Odesílatel e-mailu neodpovídá za eventuální škodu způsobenou modifikacemi či zpožděním přenosu e-mailu.

V případě, že je tento e-mail součástí obchodního jednání:
- vyhrazuje si odesílatel právo ukončit kdykoliv jednání o uzavření smlouvy, a to z jakéhokoliv důvodu i bez uvedení důvodu.
- a obsahuje-li nabídku, je adresát oprávněn nabídku bezodkladně přijmout; Odesílatel tohoto e-mailu (nabídky) vylučuje přijetí nabídky ze strany příjemce s dodatkem či odchylkou.
- trvá odesílatel na tom, že příslušná smlouva je uzavřena teprve výslovným dosažením shody na všech jejích náležitostech.
- odesílatel tohoto emailu informuje, že není oprávněn uzavírat za společnost žádné smlouvy s výjimkou případů, kdy k tomu byl písemně zmocněn nebo písemně pověřen a takové pověření nebo plná moc byly adresátovi tohoto emailu případně osobě, kterou adresát zastupuje, předloženy nebo jejich existence je adresátovi či osobě jím zastoupené známá.

This e-mail and any documents attached to it may be confidential and are intended only for its intended recipients.
If you received this e-mail by mistake, please immediately inform its sender. Delete the contents of this e-mail with all attachments and its copies from your system.
If you are not the intended recipient of this e-mail, you are not authorized to use, disseminate, copy or disclose this e-mail in any manner.
The sender of this e-mail shall not be liable for any possible damage caused by modifications of the e-mail or by delay with transfer of the email.

In case that this e-mail forms part of business dealings:
- the sender reserves the right to end negotiations about entering into a contract in any time, for any reason, and without stating any reasoning.
- if the e-mail contains an offer, the recipient is entitled to immediately accept such offer; The sender of this e-mail (offer) excludes any acceptance of the offer on the part of the recipient containing any amendment or variation.
- the sender insists on that the respective contract is concluded only upon an express mutual agreement on all its aspects.
- the sender of this e-mail informs that he/she is not authorized to enter into any contracts on behalf of the company except for cases in which he/she is expressly authorized to do so in writing, and such authorization or power of attorney is submitted to the recipient or the person represented by the recipient, or the existence of such authorization is known to the recipient of the person represented by the recipient.
______________________________________________
[hidden email] mailing list -- To UNSUBSCRIBE and more, see
https://stat.ethz.ch/mailman/listinfo/r-help
PLEASE do read the posting guide http://www.R-project.org/posting-guide.html
and provide commented, minimal, self-contained, reproducible code.
Reply | Threaded
Open this post in threaded view
|

Re: Problems with "predict" function ii

Rui Barradas
In reply to this post by R help mailing list-2
Hello,

First of all, your question is about 'predict' but you include graphic
instructions that have nothing to do with it. They do not hurt, but the
reproducible example should also be minimal.

Second, whenever you use RNG's, you should start it with set.seed().

Now, I have edited your code and it all works. No errors.
I got it rid of attach/detach and of the graphics.
And added spaces around some bits, such as <-, =, etc.


set.seed(187)    # Make the results reproducible

m <- runif(1,0,1)
m
mres <- m*(seq(1, 12))
mres
ssd <- rexp(1, 1)
ssd
devs <- rep(0, length(mres))
for(i in 1:length(mres)){
     devs[i] <- rnorm(1, 0, ssd)
}
devs
sales <- round((mres+devs)*1000)

ptr <- cbind(1:length(sales), sales, sales, sales)
ptr

sdf <- data.frame(1:nrow(ptr), sales)
colnames(sdf)<-c("monat", "mitte")
sdf

#attach(sdf)
s.lm <- lm(mitte ~ monat, sdf)
s.lm

news <- data.frame(monat = nrow(sdf) + 1)
news

fcs <- predict(s.lm, newdata = news, interval = "predict")
fcs

ptr <- rbind(ptr, c(1 + nrow(ptr), fcs[2], fcs[1], fcs[3]))
ptr

highdf <- data.frame(ptr[, c(1, 4)])
colnames(highdf) <- c("month","sales")
highdf

#detach(sdf)
#attach(highdf)
h.lm <- lm(sales ~ month, highdf)
h.lm
news <- data.frame(month = nrow(ptr) + 1)
news
hcs <- predict(h.lm, newdata = news, interval = "predict")
hcs



On 1/31/2018 5:20 PM, WRAY NICHOLAS via R-help wrote:

> I  have realised that I should have used "detach" before attaching another
> dataframe, but even when I do this it's still giving me lots of lines, rather
> than just one:
>
> My code:
>
>
> m<-runif(1,0,1)
> m
> mres<-m*(seq(1,12))
> mres
> ssd<-rexp(1,1)
> ssd
> devs<-rep(0,length(mres))
> for(i in 1:length(mres)){devs[i]<-rnorm(1,0,ssd)}
> devs
> plot(-10,-10,xlim=c(1,24),ylim=c(0,20000))
> sales<-round((mres+devs)*1000)
>
> points(sales,pch=19)
>
> ptr<-cbind(1:length(sales),sales,sales,sales)
>
> ptr
> sdf<-data.frame(cbind(1:nrow(ptr),sales))
> sdf
>
> colnames(sdf)<-c(“monat”,“mitte”)
> sdf
> attach(sdf)
> s.lm<-lm(mitte~monat)
>
> s.lm
> abline(s.lm,lty=2)
> news<-data.frame(monat=nrow(sdf)+1)
> news
> fcs<-predict(s.lm,news,interval=“predict”)
> fcs
>
> points(1+nrow(ptr),fcs[,1],col=“grey”,pch=19)
> points(1+nrow(ptr),fcs[,2])
> points(1+nrow(ptr),fcs[,3])
> ptr<-rbind(ptr,c(1+nrow(ptr),fcs[2],fcs[1],fcs[3]))
> ptr
>
> highdf<-data.frame(ptr[,c(1,4)])
> highdf
> colnames(highdf)<-c(“month”,“sales”)
> highdf
> detach(sdf)
> attach(highdf)
> h.lm<-lm(highdf[,2]~highdf[,1])
> h.lm
> abline(h.lm,col="gray",lty=2)
> news<-data.frame(month=nrow(ptr)+1)
> news
> hcs<-predict(h.lm,news,interval=“predict”)
> hcs
> [[alternative HTML version deleted]]
>
> ______________________________________________
> [hidden email] mailing list -- To UNSUBSCRIBE and more, see
> https://stat.ethz.ch/mailman/listinfo/r-help
> PLEASE do read the posting guide http://www.R-project.org/posting-guide.html
> and provide commented, minimal, self-contained, reproducible code.
>

______________________________________________
[hidden email] mailing list -- To UNSUBSCRIBE and more, see
https://stat.ethz.ch/mailman/listinfo/r-help
PLEASE do read the posting guide http://www.R-project.org/posting-guide.html
and provide commented, minimal, self-contained, reproducible code.