chron library: format.times, parse.format and h:m (PR#8507)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

chron library: format.times, parse.format and h:m (PR#8507)

Phil Spector
Due to the following lines in parse.format:


else if (nf == 3) {
        sep <- ""
        fmt <- substring(format, first = 1:3, last = 1:3)
    }

If a format code has 3 characters, it will not use a separator:

> library(chron)
> mytime = times('7:15:00')
> format(mytime,'h:m')
[1] "0715"
                                       - Phil Spector
                                         Statistical Computing Facility
                                         Department of Statistics
                                         UC Berkeley
                                         [hidden email]




--please do not edit the information below--

Version:
 platform = x86_64-pc-linux-gnu
 arch = x86_64
 os = linux-gnu
 system = x86_64, linux-gnu
 status =
 major = 2
 minor = 1.1
 year = 2005
 month = 06
 day = 20
 language = R

Locale:
C

Search Path:
 .GlobalEnv, package:chron, package:methods, package:stats, package:graphics, package:grDevices, package:utils, package:datasets, Autoloads, package:base

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Reply | Threaded
Open this post in threaded view
|

Re: chron library: format.times, parse.format and h:m (PR#8507)

Kurt Hornik
>>>>> spector  writes:

> Due to the following lines in parse.format:
> else if (nf == 3) {
>         sep <- ""
>         fmt <- substring(format, first = 1:3, last = 1:3)
>     }

> If a format code has 3 characters, it will not use a separator:

>> library(chron)
>> mytime = times('7:15:00')
>> format(mytime,'h:m')
> [1] "0715"
>                                        - Phil Spector
> Statistical Computing Facility
> Department of Statistics
> UC Berkeley
> [hidden email]

The docs say

          The times format can be any permutation of '"h"', '"m"', and
          '"s"' separated by any one non-special character.  The
          default is '"h:m:s"'.

and I would read *permutation* as to include each of h m s, so that
incomplete representations like the one you gave are ruled out.

(In any case, it seems we should teach the docs about the no-separator
case.)

-k

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel