minor problem in XML package

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

minor problem in XML package

R devel mailing list
[The package XML is labelled ORPHANED and a comment says the CRAN team
maintains it.  I am not sure what address to send this to.]

In package XML version 3.98.1.11, RUtils.c registers the C function
RS_XML_xmlNodeChildrenReferences twice.  The registration information is
identical but this could cause maintenance problems if the routine were
changed.

% grep -n RS_XML_xmlNodeChildrenReferences RUtils.c
205:        ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
231:    ENTRY(RS_XML_xmlNodeChildrenReferences, 3),

One of them should be deleted.

% diff -u XML/src/RUtils.c~ XML/src/RUtils.c
--- XML/src/RUtils.c~   2018-06-06 11:32:16.549338000 -0700
+++ XML/src/RUtils.c    2018-06-06 11:33:07.899782000 -0700
@@ -228,7 +228,6 @@
        ENTRY(RS_XML_xmlNodeName, 1),
        ENTRY(RS_XML_xmlNodeNamespace, 1),
        ENTRY(RS_XML_xmlNodeAttributes, 3),
-       ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
        ENTRY(R_xmlNodeValue, 3),
        ENTRY(R_setXMLInternalTextNode_value, 2),
        ENTRY(RS_XML_xmlNodeParent, 2),

Bill Dunlap
TIBCO Software
wdunlap tibco.com

        [[alternative HTML version deleted]]

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Reply | Threaded
Open this post in threaded view
|

Re: minor problem in XML package

Duncan Temple Lang-3
Thanks Bill.
It has been changed in the github repository for the package for a while
now.
Thanks for pointing out.

D.

On Wed, Jun 6, 2018 at 11:40 AM William Dunlap via R-devel <
[hidden email]> wrote:

> [The package XML is labelled ORPHANED and a comment says the CRAN team
> maintains it.  I am not sure what address to send this to.]
>
> In package XML version 3.98.1.11, RUtils.c registers the C function
> RS_XML_xmlNodeChildrenReferences twice.  The registration information is
> identical but this could cause maintenance problems if the routine were
> changed.
>
> % grep -n RS_XML_xmlNodeChildrenReferences RUtils.c
> 205:        ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
> 231:    ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
>
> One of them should be deleted.
>
> % diff -u XML/src/RUtils.c~ XML/src/RUtils.c
> --- XML/src/RUtils.c~   2018-06-06 11:32:16.549338000 -0700
> +++ XML/src/RUtils.c    2018-06-06 11:33:07.899782000 -0700
> @@ -228,7 +228,6 @@
>         ENTRY(RS_XML_xmlNodeName, 1),
>         ENTRY(RS_XML_xmlNodeNamespace, 1),
>         ENTRY(RS_XML_xmlNodeAttributes, 3),
> -       ENTRY(RS_XML_xmlNodeChildrenReferences, 3),
>         ENTRY(R_xmlNodeValue, 3),
>         ENTRY(R_setXMLInternalTextNode_value, 2),
>         ENTRY(RS_XML_xmlNodeParent, 2),
>
> Bill Dunlap
> TIBCO Software
> wdunlap tibco.com
>
>         [[alternative HTML version deleted]]
>
> ______________________________________________
> [hidden email] mailing list
> https://stat.ethz.ch/mailman/listinfo/r-devel
>
--
Duncan Temple Lang
Director, Data Science Initiative
Professor of Statistics

        [[alternative HTML version deleted]]

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel