grDevice in R HEAD been broken for 6 weeks.

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

grDevice in R HEAD been broken for 6 weeks.

Hin-Tak Leung
geDevice has been failing check for 6 weeks now with --enable-strict-barrier ,
bisected to:

------------------------------------------------------------------------
r69049 | murrell | 2015-08-14 00:03:12 +0100 (Fri, 14 Aug 2015) | 2 lines

first hack at adding grid display list to recorded plot objects, so can add further grid drawing following a replayPlot()

------------------------------------------------------------------------

It seems to be broken by the GE_SaveSnapshotState addition
in src/library/grid/src/state.c:

     case GE_SaveSnapshotState:
+        /*
+         * Save the current 'grid' DL.
+         */
+        PROTECT(result = allocVector(VECSXP, 3));
+        SET_VECTOR_ELT(result, 0, gridStateElement(dd, GSS_DL));
+        SET_VECTOR_ELT(result, 1, gridStateElement(dd, GSS_DLINDEX));
+        UNPROTECT(1);
        break;

> showCols2()
Loading required package: grid
Error in grDevices:::recordPalette() :
  LOGICAL() can only be applied to a 'logical', not a 'list'
Calls: demo ... eval -> eval -> showCols2 -> grid.newpage -> <Anonymous>
Execution halted

somewhere else it seems to expect the outcome of GE_SaveSnapshotState to be
a logical array rather than a list, though I cannot find where it is.

Any chance of that getting fixed any time soon?

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel
Reply | Threaded
Open this post in threaded view
|

Re: grDevice in R HEAD been broken for 6 weeks.

Paul Murrell-2
Hi

This should be fixed in r-devel r69442.

Thanks very much for reporting the problem!

Paul

On 26/09/15 19:39, Hin-Tak Leung wrote:

> geDevice has been failing check for 6 weeks now with --enable-strict-barrier ,
> bisected to:
>
> ------------------------------------------------------------------------
> r69049 | murrell | 2015-08-14 00:03:12 +0100 (Fri, 14 Aug 2015) | 2 lines
>
> first hack at adding grid display list to recorded plot objects, so can add further grid drawing following a replayPlot()
>
> ------------------------------------------------------------------------
>
> It seems to be broken by the GE_SaveSnapshotState addition
> in src/library/grid/src/state.c:
>
>       case GE_SaveSnapshotState:
> +        /*
> +         * Save the current 'grid' DL.
> +         */
> +        PROTECT(result = allocVector(VECSXP, 3));
> +        SET_VECTOR_ELT(result, 0, gridStateElement(dd, GSS_DL));
> +        SET_VECTOR_ELT(result, 1, gridStateElement(dd, GSS_DLINDEX));
> +        UNPROTECT(1);
>          break;
>
>> showCols2()
> Loading required package: grid
> Error in grDevices:::recordPalette() :
>    LOGICAL() can only be applied to a 'logical', not a 'list'
> Calls: demo ... eval -> eval -> showCols2 -> grid.newpage -> <Anonymous>
> Execution halted
>
> somewhere else it seems to expect the outcome of GE_SaveSnapshotState to be
> a logical array rather than a list, though I cannot find where it is.
>
> Any chance of that getting fixed any time soon?
>

--
Dr Paul Murrell
Department of Statistics
The University of Auckland
Private Bag 92019
Auckland
New Zealand
64 9 3737599 x85392
[hidden email]
http://www.stat.auckland.ac.nz/~paul/

______________________________________________
[hidden email] mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel